saurabhd336 commented on code in PR #10254:
URL: https://github.com/apache/pinot/pull/10254#discussion_r1106759288
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BaseImmutableDictionary.java:
##########
@@ -279,4 +281,39 @@ protected byte[] getBytes(int dictId) {
protected byte[] getBuffer() {
return new byte[_numBytesPerValue];
}
+
+ public void getDictIds(List<String> values, IntSet dictIds, int
inPredicateSparseThreshold,
+ int inPredicateSortThreshold) {
+ if (length() / values.size() > inPredicateSparseThreshold || values.size()
< inPredicateSortThreshold) {
+ for (String value : values) {
Review Comment:
Infact, if we write another binSearch implementation, which returns the
index closest (but not greated) to the value being searched (and another
indicator of whether the value actually matched), each of these searches will
necessarily reduce the search space for the next value in the sorted list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
