saurabhd336 commented on code in PR #10254:
URL: https://github.com/apache/pinot/pull/10254#discussion_r1106749127
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/PredicateUtils.java:
##########
@@ -139,10 +143,40 @@ public static IntSet getDictIdSet(BaseInPredicate
inPredicate, Dictionary dictio
}
break;
case STRING:
- for (String value : values) {
- int dictId = dictionary.indexOf(value);
- if (dictId >= 0) {
- dictIdSet.add(dictId);
+ if (values.size() >
RequestContextUtils.THRESHOLD_OF_LARGE_IN_CLAUSE_VALUES) {
Review Comment:
I was thinking if we can still benefit from the strings being sorted in this
scenario if we use something like
https://github.com/apache/pinot/pull/10254#discussion_r1106747320?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
