gortiz commented on code in PR #10191: URL: https://github.com/apache/pinot/pull/10191#discussion_r1092995267
########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/IndexDeclaration.java: ########## @@ -0,0 +1,114 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.pinot.segment.spi.index; + +import com.google.common.base.Preconditions; +import java.util.Objects; +import javax.annotation.Nullable; + + +// This should be a sealed class in modern Java +public class IndexDeclaration<C> { Review Comment: In this partial PR doesn't seem to be needed, but it is needed in the PR with all the changes, mainly to: 1. Be able to correctly merge new and old syntax 2. Remove undeclared values default values when config is serialized as JSON. Also, it doesn't hurt. We could model the config as not null when enabled and null when disabled, but I think it is better to have a model with semantic values where disabled is modeled with an actual object. Once you do that, you need the `IndexDeclaration` indirection, so we need to pay for the object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
