sajjad-moradi commented on code in PR #10186:
URL: https://github.com/apache/pinot/pull/10186#discussion_r1088501494
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/IntermediateIndexContainer.java:
##########
@@ -61,9 +61,10 @@ public IntermediateIndexContainer(FieldSpec fieldSpec,
@Nullable PartitionFuncti
}
public DataSource toDataSource(int numDocsIndexed) {
+ // TODO(Vivek): Change to correct value of maxRowLengthInBytes
return new MutableDataSource(_fieldSpec, numDocsIndexed,
_numValuesInfo._numValues,
_numValuesInfo._maxNumValuesPerMVEntry, _dictionary.length(),
_partitionFunction, _partitions, _minValue,
- _maxValue, _forwardIndex, _dictionary, null, null, null, null, null,
null, null, null);
+ _maxValue, _forwardIndex, _dictionary, null, null, null, null, null,
null, null, null, -1);
Review Comment:
I'm not sure where IntermediateSegment is being used. Based on the other
parameters, I assume using -1 should be fine! In any case, please remove the
TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
