jugomezv commented on code in PR #10106:
URL: https://github.com/apache/pinot/pull/10106#discussion_r1081595797
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java:
##########
@@ -481,20 +461,6 @@ public long getValueOfTableGauge(final String tableName,
final G gauge) {
return gaugeValue == null ? 0 : gaugeValue.get();
}
- /**
- * Gets the value of a table partition gauge.
- *
- * @param tableName The table name
- * @param partitionId The partition name
- * @param gauge The gauge to use
- */
- public long getValueOfPartitionGauge(final String tableName, final int
partitionId, final G gauge) {
- final String fullGaugeName = composeTableGaugeName(tableName,
String.valueOf(partitionId), gauge);
-
- AtomicLong gaugeValue = _gaugeValues.get(fullGaugeName);
- return gaugeValue == null ? -1 : gaugeValue.get();
Review Comment:
So should this be Visible for testing only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
