jugomezv commented on code in PR #10106:
URL: https://github.com/apache/pinot/pull/10106#discussion_r1070080008
##########
pinot-controller/src/test/java/org/apache/pinot/controller/validation/StorageQuotaCheckerTest.java:
##########
@@ -104,33 +105,39 @@ public void testWithinQuota()
// No response from server, should pass without updating metrics
mockTableSizeResult(-1, 0);
assertTrue(isSegmentWithinQuota());
- assertEquals(
- controllerMetrics.getValueOfTableGauge(OFFLINE_TABLE_NAME,
ControllerGauge.OFFLINE_TABLE_ESTIMATED_SIZE), 0);
+ assertFalse(
+ MetricValueUtils.gaugeExists(controllerMetrics,
Review Comment:
similar comment here: should we have a MetricValueUtils.tableGaugeExists()
than pass name of table as an argument?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
