ankitsultana commented on code in PR #9873: URL: https://github.com/apache/pinot/pull/9873#discussion_r1071032075
########## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/operator/exchange/HashExchangeTest.java: ########## @@ -105,5 +106,10 @@ public Object[] getKey(Object[] input) { public int computeHash(Object[] input) { return _hashes.next(); } + + @Override + public String hashAlgorithm() { + return HASH_ALGORITHM; Review Comment: Representing as enum would be hard since each implementaiton of `KeySelector` will have their own names to identify themselves which may be across different packages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org