61yao commented on code in PR #10094:
URL: https://github.com/apache/pinot/pull/10094#discussion_r1070465845
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -69,18 +74,22 @@ public class AggregateOperator extends
BaseOperator<TransferableBlock> {
private boolean _readyToConstruct;
private boolean _hasReturnedAggregateBlock;
+ // TODO: Move to OperatorContext class.
+ private OperatorStats _operatorStats;
+
// TODO: refactor Pinot Reducer code to support the intermediate stage agg
operator.
// aggCalls has to be a list of FunctionCall and cannot be null
// groupSet has to be a list of InputRef and cannot be null
// TODO: Add these two checks when we confirm we can handle error in
upstream ctor call.
public AggregateOperator(Operator<TransferableBlock> inputOperator,
DataSchema dataSchema,
- List<RexExpression> aggCalls, List<RexExpression> groupSet) {
- this(inputOperator, dataSchema, aggCalls, groupSet,
AggregateOperator.Accumulator.MERGERS);
+ List<RexExpression> aggCalls, List<RexExpression> groupSet,
PlanRequestContext context) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
