walterddr commented on code in PR #10094:
URL: https://github.com/apache/pinot/pull/10094#discussion_r1068804425
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java:
##########
@@ -58,17 +60,23 @@
*/
public class LeafStageTransferableBlockOperator extends
BaseOperator<TransferableBlock> {
private static final String EXPLAIN_NAME = "LEAF_STAGE_TRANSFER_OPERATOR";
+ private static final Logger LOGGER =
LoggerFactory.getLogger(LeafStageTransferableBlockOperator.class);
private final InstanceResponseBlock _errorBlock;
private final List<InstanceResponseBlock> _baseResultBlock;
private final DataSchema _desiredDataSchema;
private int _currentIndex;
- public LeafStageTransferableBlockOperator(List<InstanceResponseBlock>
baseResultBlock, DataSchema dataSchema) {
+ // TODO: Move to OperatorContext class.
+ private OperatorStats _operatorStats;
+
+ public LeafStageTransferableBlockOperator(List<InstanceResponseBlock>
baseResultBlock, DataSchema dataSchema,
+ long requestId, int stageId) {
Review Comment:
let's try to be consistent here. i think passing requestID and stageId is
best for all the constructors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
