egalpin commented on code in PR #10092:
URL: https://github.com/apache/pinot/pull/10092#discussion_r1068461443
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/query/FilteredGroupByOperator.java:
##########
@@ -60,8 +61,10 @@ public class FilteredGroupByOperator extends
BaseOperator<GroupByResultsBlock> {
private long _numEntriesScannedPostFilter;
private final DataSchema _dataSchema;
private final QueryContext _queryContext;
+ private final IdentityHashMap<AggregationFunction, Integer>
_resultHolderIndexMap;
Review Comment:
My thought on this change was to avoid the need to recompute this map on
every call to `getNextBlock` and instead compute once on instantiation and
reuse the map across calls to `getNextBlock`.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
