egalpin commented on code in PR #10092:
URL: https://github.com/apache/pinot/pull/10092#discussion_r1068457903
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/results/AggregationResultsBlock.java:
##########
@@ -69,7 +84,14 @@ public DataSchema getDataSchema(QueryContext queryContext) {
ColumnDataType[] columnDataTypes = new ColumnDataType[numColumns];
for (int i = 0; i < numColumns; i++) {
AggregationFunction aggregationFunction = _aggregationFunctions[i];
- columnNames[i] = aggregationFunction.getColumnName();
+ String columnName = aggregationFunction.getResultColumnName();
Review Comment:
I had mistakenly assumed that this change was needed to ensure that
non-group-by filtered aggs had their result column names accurately reflected.
That appears to not be the case having confirmed that tests still pass after
removing these changes.
Is it at all problematic that this section of code would be "out of sync"
with other sections of code as it pertains to column naming?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
