[GitHub] [pinot] richardstartin commented on a diff in pull request #10077: Add an option to reduce random access by caching fields of visited nodes when doing BFS over StarTree index

[GitBox]

richardstartin commented on code in PR #10077:
URL: https://github.com/apache/pinot/pull/10077#discussion_r1064140835


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/OffHeapStarTreeNode.java:
##########
@@ -39,11 +39,13 @@ public class OffHeapStarTreeNode implements StarTreeNode {
   private final PinotDataBuffer _dataBuffer;
   private final int _nodeId;
   private final int _firstChildId;
+  private final int _lastChildId;

Review Comment:
   For future reference, in case you haven't used it before, you can actually 
measure it on Hotspot using 
[jol](https://mvnrepository.com/artifact/org.openjdk.jol/jol-core/0.16). You 
just write something like:
   
   ```java
   System.out.println(ClassLayout.parseClass(StarTreeNode.class).toPrintable());
   ```
   
   But this takes into account you JVM settings, so if you really want to go 
above 32GiB heap you'd have to disable compressed oops.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org