mcvsubbu commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1061906746
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1594,4 +1616,9 @@ public String getSegmentName() {
public void forceCommit() {
_forceCommitMessageReceived = true;
}
+
+ @Override
+ public void notifyConsumptionCaughtUp(boolean catchingUpPhase) {
Review Comment:
The ingestion-based status checkers have a specific purpose -- to answer the
question of whether the ingestion has caught up "reasonably" before we can
start to field queries after server startup. Once the server is started up, we
should be fielding queries no matter whether ingestion is caught up or not.
The way to handle this situation is to do one of the following:
- Ignore the startup part -- at least for now. Yes, we may show a lag until
it catches up, but it is useful metric to observe as well. I _strongly_
suggest going this approach in the beginning.
- My less preferred approach is to plumb the code so as to keep the
ingestion delay trackers disabled until the server has started up completely.
I don't feel comfortable handling it as a part of this PR, since we may
introduce unintentional circular dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
