navina commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1061817534


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1594,4 +1616,9 @@ public String getSegmentName() {
   public void forceCommit() {
     _forceCommitMessageReceived = true;
   }
+
+  @Override
+  public void notifyConsumptionCaughtUp(boolean catchingUpPhase) {

Review Comment:
   This might be the case because the ingestion based status checkers are not 
aware of the new segments that were not around when the server started. 
   Wouldn't that indicate an issue with the ingestion based status checkers 
itself, then?  Shouldn't it also detect new segments if the segment rolls over 
during catch-up? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to