navina commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1061832162
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TTLPartitionUpsertMetadataManager.java: ########## @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.upsert; + +import java.util.Iterator; +import java.util.List; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.TimeUnit; +import javax.annotation.Nullable; +import javax.annotation.concurrent.ThreadSafe; +import org.apache.pinot.common.metrics.ServerMetrics; +import org.apache.pinot.segment.local.utils.HashUtils; +import org.apache.pinot.segment.spi.IndexSegment; +import org.apache.pinot.spi.config.table.HashFunction; + + +/** + * Implementation of {@link PartitionUpsertMetadataManager} that is backed by a {@link ConcurrentHashMap}. + * Used by Upsert TTL (Time-to-live) feature. + */ +@SuppressWarnings({"rawtypes", "unchecked"}) +@ThreadSafe +public class TTLPartitionUpsertMetadataManager extends ConcurrentMapPartitionUpsertMetadataManager { Review Comment: You can add more methods to it. But my point was that this TTL feature will only work with `ConcurrentMapPartitionUpsertMetadataManager` and none of the other implementations of `PartitionUpsertMetadataManager`. I don't think that was the intention in the design. Please correct me if I am missing something here. It will be better to model this as a separate component or a wrapper around any of the `PartitionUpsertMetadataManager`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
