navina commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1060307292
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/UpsertTTLStrategy.java: ########## @@ -0,0 +1,34 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.upsert; + +import java.util.concurrent.TimeUnit; + + +public class UpsertTTLStrategy { Review Comment: can you add javadocs for this class? IIuc, this seems to be a class to hold the values from `UpsertTTLConfig` with an additional method to convert to millis. So, is this class really needed? ########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TTLPartitionUpsertMetadataManager.java: ########## @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.upsert; + +import java.util.Iterator; +import java.util.List; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.TimeUnit; +import javax.annotation.Nullable; +import javax.annotation.concurrent.ThreadSafe; +import org.apache.pinot.common.metrics.ServerMetrics; +import org.apache.pinot.segment.local.utils.HashUtils; +import org.apache.pinot.segment.spi.IndexSegment; +import org.apache.pinot.spi.config.table.HashFunction; + + +/** + * Implementation of {@link PartitionUpsertMetadataManager} that is backed by a {@link ConcurrentHashMap}. + * Used by Upsert TTL (Time-to-live) feature. + */ +@SuppressWarnings({"rawtypes", "unchecked"}) +@ThreadSafe +public class TTLPartitionUpsertMetadataManager extends ConcurrentMapPartitionUpsertMetadataManager { Review Comment: why is this class needed when you can just override the method `removeExpiredPrimaryKeys` in `ConcurrentMapPartitionUpsertMetadataManager`? Same question on `TTLTableUpsertMetadataManager`. ########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ########## @@ -162,6 +165,9 @@ protected abstract void addOrReplaceSegment(ImmutableSegmentImpl segment, Thread Iterator<RecordInfo> recordInfoIterator, @Nullable IndexSegment oldSegment, @Nullable MutableRoaringBitmap validDocIdsForOldSegment); + protected abstract void removeExpiredPrimaryKeys(IndexSegment segment, Iterator<RecordInfo> recordInfoIterator, Review Comment: Can you add some javadocs for this new method? Also, I think this method should be included as a part of the `PartitionUpsertMetadataManager` interface itself since it manipulates the partition metadata. Is there a reason why it is not included as a part of the interface? ########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertTTLConfig.java: ########## @@ -0,0 +1,54 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.config.table; + +import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.annotation.JsonPropertyDescription; +import javax.annotation.Nullable; + + +public class UpsertTTLConfig { + + @JsonPropertyDescription("ttl time unit") + private String _ttlTimeUnit; + @JsonPropertyDescription("ttl time value") + private String _ttlTimeValue; Review Comment: 1. can you include java docs for this class 2. It will be useful to include the supported time units in the `@JsonPropertyDescription` for `_ttlTimeUnit` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
