richardstartin opened a new pull request, #10044: URL: https://github.com/apache/pinot/pull/10044
This pushes the unsigned comparison operation down into the `ValueReader` so that a string doesn't need to be materialised to do the comparison. For `FixedByteValueReaderWriter`, which has showed up as a CPU bottleneck in pretty much every profile of Pinot query evaluation I have looked at, because the work done to find where the string ends within the fixed width bucket before copying the string can be skipped. I will mark this as ready for review once I've run some benchmarks to demonstrate the impact of the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
