vvivekiyer commented on code in PR #9982:
URL: https://github.com/apache/pinot/pull/9982#discussion_r1049985513
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/utils/SegmentMetadataUtils.java:
##########
@@ -50,11 +51,15 @@ public static void
savePropertiesConfiguration(PropertiesConfiguration propertie
CommonsConfigurationUtils.saveToFile(propertiesConfiguration,
metadataFile);
}
- public static void updateMetadataProperties(SegmentMetadata segmentMetadata,
Map<String, String> metadataProperties) {
+ public static SegmentMetadata updateMetadataProperties(SegmentMetadata
segmentMetadata, Map<String,
Review Comment:
segmentMetadata is redundant here, right? Can we can fetch it from
segmentDirectory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
