[GitHub] [pinot] vvivekiyer commented on a diff in pull request #9982: Reload the SegmentMetadata even for temporary forward index

[GitBox]

vvivekiyer commented on code in PR #9982:
URL: https://github.com/apache/pinot/pull/9982#discussion_r1048876576


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/BaseIndexHandler.java:
##########
@@ -93,6 +100,24 @@ protected void 
createForwardIndexIfNeeded(SegmentDirectory.Writer segmentWriter,
       _tmpForwardIndexColumns.add(columnName);
     }
 
+    // Update the segmentMetadata
+    File indexDir = _segmentMetadata.getIndexDir();

Review Comment:
   I was thinking we could just change the signature of 
`updateMetadataProperties` as follows:
   
   `public static SegmentMetadata  updateMetadataProperties(SegmentMetadata 
segmentMetadata, Map<String, String> metadataProperties, File indexDir)`
   
   Now we can just call,
   `_segmentMetadata = updateMetadataProperties(...) `everywhere. 
   
   Does that work?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org