somandal commented on PR #9810: URL: https://github.com/apache/pinot/pull/9810#issuecomment-1346835217
> @somandal - looks good overall. Since this is quite big already and we have iterated upon it few times, I am merging it. I think the runtime of MV column should be looked into once to see there isn't any performance issue. > > Secondly, it will be good to take another pass at the new file added to see if some methods can be refactored into smaller ones. > > Thanks for working on this. Thanks so much, appreciate your patience with this long PR! I'll look into: > Secondly, it will be good to take another pass at the new file added to see if some methods can be refactored into smaller ones. As for this: > I think the runtime of MV column should be looked into once to see there isn't any performance issue. The MV test taking 7-8 minutes is spending most of that time on verification and not on reload. So I don't anticipate a major issue in the reload path for performance purposes, but I can definitely look into whether there are any optimization opportunities. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
