somandal commented on code in PR #9810:
URL: https://github.com/apache/pinot/pull/9810#discussion_r1046055618


##########
pinot-core/src/test/java/org/apache/pinot/queries/ForwardIndexDisabledSingleValueQueriesTest.java:
##########
@@ -845,6 +845,69 @@ public void testSelectQueriesWithReload()
       assertEquals(resultRow[0], 240528);
       assertEquals(resultRow[1], "gFuH");
     }
+
+    // Re-enable forward index for column9, column11, and column6

Review Comment:
   The reload isn't taking 7-8 minutes. The verification is taking that long. 
Need to walk through 400K rows, construct the sets for before and after and 
validate that they match. I did validate that the reload part is quick, so 
there shouldn't be a major performance issue with the reload part itself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to