ankitsultana commented on code in PR #9808:
URL: https://github.com/apache/pinot/pull/9808#discussion_r1029878486
##########
pinot-broker/src/test/java/org/apache/pinot/broker/routing/instanceselector/InstanceSelectorTest.java:
##########
@@ -814,14 +837,121 @@ public void
testReplicaGroupInstanceSelectorNumReplicaGroupsNotSet() {
for (String segment: segments) {
expectedReplicaGroupInstanceSelectorResult.put(segment, instance0);
}
- InstanceSelector.SelectionResult selectionResult =
replicaGroupInstanceSelector.select(brokerRequest, segments);
+ InstanceSelector.SelectionResult selectionResult =
replicaGroupInstanceSelector.select(brokerRequest, segments, 0);
assertEquals(selectionResult.getSegmentToInstanceMap(),
expectedReplicaGroupInstanceSelectorResult);
for (String segment: segments) {
expectedReplicaGroupInstanceSelectorResult.put(segment, instance1);
}
- selectionResult = replicaGroupInstanceSelector.select(brokerRequest,
segments);
+ selectionResult = replicaGroupInstanceSelector.select(brokerRequest,
segments, 1);
+ assertEquals(selectionResult.getSegmentToInstanceMap(),
expectedReplicaGroupInstanceSelectorResult);
+ }
+
+ @Test
+ public void testMultiStageStrictReplicaGroupSelector() {
Review Comment:
self-review: add comments to describe what the test is doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
