navina commented on PR #9835: URL: https://github.com/apache/pinot/pull/9835#issuecomment-1322780076
Spoke with @Jackie-Jiang offline. I think my suggestion was coming from a cleaner code point of view that doesn't expose functionality (which otherwise may not be necessary to different components of the system) and to improve testability. I still think there should be very little need to access functionality from a higher level. Data access can be done without passing the entire instance. But it looks like we are a little too deep in the weeds to simplify this right now :) Closing this and will re-visit the pattern later. Tks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
