navina opened a new pull request, #9835: URL: https://github.com/apache/pinot/pull/9835
Passing `this` as an argument can lead to concurrency issues. Removing `TableDataManager` instance from `TableUpsertMetadataManager#init` interface as it is not actually used. `TableUpsertMetadataManager` is created by the `TableDataManager`. Hence, any required data can be passed in directly without exposing `this`. Note: Kept the change backward compatibility , although I don't see a reason why we can't just remove it. It is an internal API. Label: `refactor` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
