walterddr commented on code in PR #9818:
URL: https://github.com/apache/pinot/pull/9818#discussion_r1025901955
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##########
@@ -129,6 +130,9 @@ public QueryPlan planQuery(String sqlQuery,
SqlNodeAndOptions sqlNodeAndOptions)
plannerContext.setOptions(sqlNodeAndOptions.getOptions());
RelRoot relRoot = compileQuery(sqlNodeAndOptions.getSqlNode(),
plannerContext);
return toDispatchablePlan(relRoot, plannerContext);
+ } catch (CalciteContextException e) {
+ throw new RuntimeException("Error composing query plan for '" + sqlQuery
+ + "': " + e.getMessage() + "'", e);
Review Comment:
hmm. I am not 100% sure i understand. `e.getMessage()` is also included in
the `e` part which is also part of the other catch clause branch below correct?
or the other way to ask is why can't we add e.getMessage() to both branches
of catch exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
