61yao commented on code in PR #9818: URL: https://github.com/apache/pinot/pull/9818#discussion_r1025845163
########## pinot-query-runtime/src/test/resources/queries/TimeTypes.json: ########## @@ -0,0 +1,72 @@ +{ + "ts_without_tz": { + "tables": { + "ts": { + "schema": [ + {"name": "data", "type": "TIMESTAMP"} + ], + "inputs": [ + ["1999-01-08 04:05:06"], + ["1999-01-08 22:05:46"], + ["1999-01-08 04:05:06.001"], + ["5760-01-01 04:05:06"] + ] + } + }, + "queries": [ + { + "psql": "8.5.1.3", + "description": "should support timestamps with various values", Review Comment: I thought we don't support time and byte types yet since there are a lot of functions we don't support yet. @walterddr We were saying earlier we only support primitive types + string for v2 engine now. Does this narrative change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org