walterddr commented on code in PR #9817: URL: https://github.com/apache/pinot/pull/9817#discussion_r1025551561
########## pinot-query-runtime/src/test/resources/queries/TableExpressions.json: ########## @@ -0,0 +1,93 @@ +{ + "where_clause_tests": { + "psql": "7.2.2", + "tables": { + "tbl": { + "schema": [ + {"name": "strCol", "type": "STRING"}, + {"name": "intCol", "type": "INT"} + ], + "inputs": [ + ["foo", 1], + ["bar", 2], + ["alice", 42], + ["bob", 196883] + ] + } + }, + "queries": [ + { "sql": "SELECT * FROM {tbl} WHERE intCol > 5" }, + { "sql": "SELECT * FROM {tbl} WHERE strCol IN ('foo', 'bar')" }, + { "sql": "SELECT * FROM {tbl} WHERE intCol IN (196883, 42)" }, + { "sql": "SELECT * FROM {tbl} WHERE strCol IN (SELECT strCol FROM {tbl} WHERE intCol > 100)" }, + { "sql": "SELECT * FROM {tbl} WHERE intCol < (SELECT SUM(intCol) FROM {tbl} AS b WHERE strCol BETWEEN 'bar' AND 'foo')" }, + { "sql": "SELECT * FROM {tbl} WHERE intCol BETWEEN 0 AND 100 AND strCol BETWEEN 'bar' AND 'foo'" }, + { + "ignored": true, + "comments": "Relation Decorrelator not supported", + "sql": "SELECT * FROM {tbl} AS a WHERE a.strCol IN (SELECT b.strCol FROM {tbl} AS b WHERE b.intCol = a.intCol + 1)" Review Comment: added. none are supported but added with ignore flag ########## pinot-query-runtime/src/test/resources/queries/TableExpressions.json: ########## @@ -0,0 +1,93 @@ +{ + "where_clause_tests": { + "psql": "7.2.2", + "tables": { + "tbl": { + "schema": [ + {"name": "strCol", "type": "STRING"}, + {"name": "intCol", "type": "INT"} + ], + "inputs": [ + ["foo", 1], + ["bar", 2], + ["alice", 42], + ["bob", 196883] + ] + } + }, + "queries": [ + { "sql": "SELECT * FROM {tbl} WHERE intCol > 5" }, + { "sql": "SELECT * FROM {tbl} WHERE strCol IN ('foo', 'bar')" }, + { "sql": "SELECT * FROM {tbl} WHERE intCol IN (196883, 42)" }, + { "sql": "SELECT * FROM {tbl} WHERE strCol IN (SELECT strCol FROM {tbl} WHERE intCol > 100)" }, + { "sql": "SELECT * FROM {tbl} WHERE intCol < (SELECT SUM(intCol) FROM {tbl} AS b WHERE strCol BETWEEN 'bar' AND 'foo')" }, + { "sql": "SELECT * FROM {tbl} WHERE intCol BETWEEN 0 AND 100 AND strCol BETWEEN 'bar' AND 'foo'" }, + { + "ignored": true, + "comments": "Relation Decorrelator not supported", + "sql": "SELECT * FROM {tbl} AS a WHERE a.strCol IN (SELECT b.strCol FROM {tbl} AS b WHERE b.intCol = a.intCol + 1)" + }, + { + "ignored": true, + "comments": "BETWEEN with a non-deterministic single-value result from sub-query is not supported", + "sql": "SELECT * FROM {tbl} AS a WHERE a.intCol BETWEEN (SELECT b.intCol FROM {tbl} AS b WHERE b.intCol = a.intCol + 1) AND 100" + }, + { + "ignored": true, + "comments": "Relation Decorrelator not supported", + "sql": "SELECT * FROM {tbl} AS a WHERE a.intCol BETWEEN (SELECT MIN(b.intCol) FROM {tbl} AS b WHERE b.intCol = a.intCol + 1) AND 100" + }, + { + "ignored": true, + "comments": "EXISTS not supported", + "sql": "SELECT * FROM {tbl} AS a WHERE EXISTS (SELECT strCol FROM {tbl} AS b WHERE b.intCol = a.intCol + 1)" Review Comment: added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org