[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9817: [multistage][test] add table expression tests

[GitBox]

siddharthteotia commented on code in PR #9817:
URL: https://github.com/apache/pinot/pull/9817#discussion_r1025454080


##########
pinot-query-runtime/src/test/resources/queries/TableExpressions.json:
##########
@@ -0,0 +1,93 @@
+{
+  "where_clause_tests": {
+    "psql": "7.2.2",
+    "tables": {
+      "tbl": {
+        "schema": [
+          {"name": "strCol", "type": "STRING"},
+          {"name": "intCol", "type": "INT"}
+        ],
+        "inputs": [
+          ["foo", 1],
+          ["bar", 2],
+          ["alice", 42],
+          ["bob", 196883]
+        ]
+      }
+    },
+    "queries": [
+      { "sql": "SELECT * FROM {tbl} WHERE intCol > 5" },
+      { "sql": "SELECT * FROM {tbl} WHERE strCol IN ('foo', 'bar')" },
+      { "sql": "SELECT * FROM {tbl} WHERE intCol IN (196883, 42)" },
+      { "sql": "SELECT * FROM {tbl} WHERE strCol IN (SELECT strCol FROM {tbl} 
WHERE intCol > 100)" },
+      { "sql": "SELECT * FROM {tbl} WHERE intCol < (SELECT SUM(intCol) FROM 
{tbl} AS b WHERE strCol BETWEEN 'bar' AND 'foo')" },

Review Comment:
   Can we also add tests or TODO for `ALL` (supported by Postgres) ?
   
   For example to find the department with highest average salary
   
   ```
   SELECT deptId, AVG(salary) 
   FROM emp
   GROUP BY deptId
   HAVING AVG(salary) >= ALL (
                           SELECT AVG(salary) FROM emp
                           GROUP BY deptId
                      );
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org