bagipriyank commented on issue #9393: URL: https://github.com/apache/pinot/issues/9393#issuecomment-1317578948
I think I know what is happening From https://github.com/apache/pinot/blob/c9a6e5207a6cedf325f4abaeac2970077ab5685d/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java#L241 ``` // Clean up the segment data on default tier unconditionally. File segmentDir = getSegmentDataDirectory(tableNameWithType, segmentName); if (segmentDir.exists()) { FileUtils.deleteQuietly(segmentDir); LOGGER.info("Deleted segment directory {} on default tier", segmentDir); } ``` Now from https://github.com/apache/pinot/blob/c9a6e5207a6cedf325f4abaeac2970077ab5685d/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java#L507 ``` /** * Assemble the path to segment dir directly, when table mgr object is not * created for the given table yet. */ @Override public File getSegmentDataDirectory(String tableNameWithType, String segmentName) { return new File(new File(_instanceDataManagerConfig.getInstanceDataDir(), tableNameWithType), segmentName); } ``` in our case this is point to `/var/pinot/server/data/index/students_OFFLINE/students_OFFLINE_1597044264380_1597044264670_0` instead of `/var/pinot/server/data/index/students_OFFLINE_1597044264380_1597044264670_0` which leaves the delete as a no-op. How can i verify / test this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
