walterddr commented on code in PR #9721:
URL: https://github.com/apache/pinot/pull/9721#discussion_r1013539160
##########
pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java:
##########
@@ -680,29 +680,4 @@ public String toString() {
}
return stringBuilder.toString();
}
Review Comment:
since BaseDataBlock doesn't use ANY of the DataTable API. another way to
refactor is to completely decoupled DataTable and DataBlock into 2 separate
construct.
--> now that https://github.com/apache/pinot/pull/9561/ is in, we can
actually do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
