navina commented on code in PR #9511:
URL: https://github.com/apache/pinot/pull/9511#discussion_r1009801177
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -545,23 +545,31 @@ private boolean processStreamEvents(MessageBatch
messagesAndOffsets, long idlePi
// Decode message
StreamDataDecoderResult decodedRow =
_streamDataDecoder.decode(messagesAndOffsets.getStreamMessage(index));
RowMetadata msgMetadata =
messagesAndOffsets.getStreamMessage(index).getMetadata();
+ GenericRow decoderResult;
if (decodedRow.getException() != null) {
- // TODO: based on a config, decide whether the record should be
silently dropped or stop further consumption on
- // decode error
- realtimeRowsDroppedMeter =
- _serverMetrics.addMeteredTableValue(_metricKeyName,
ServerMeter.INVALID_REALTIME_ROWS_DROPPED, 1,
- realtimeRowsDroppedMeter);
+ if (_tableConfig.getIngestionConfig() != null
+ && _tableConfig.getIngestionConfig().isContinueOnError()) {
+ decoderResult = null;
+ realtimeRowsDroppedMeter =
+ _serverMetrics.addMeteredTableValue(_metricKeyName,
ServerMeter.INVALID_REALTIME_ROWS_DROPPED, 1,
+ realtimeRowsDroppedMeter);
+ } else {
+ throw new RuntimeException("Caught exception while decoding record",
decodedRow.getException());
Review Comment:
Ideally, we would want users to "opt-in" for `continueOnError`. So, I think
it should be fine to make this incompatible change. The default behavior should
be to stop the ingestion on error.
@npawar any concerns with this backward incompatible change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
