KKcorps commented on code in PR #9511:
URL: https://github.com/apache/pinot/pull/9511#discussion_r988609896
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/SegmentGeneratorConfig.java:
##########
@@ -142,7 +144,9 @@ public SegmentGeneratorConfig(TableConfig tableConfig,
Schema schema) {
Preconditions.checkNotNull(schema);
Preconditions.checkNotNull(tableConfig);
_timestampIndexConfigs.putAll(extractTimestampIndexConfigsFromTableConfig(tableConfig));
- setSchema(updateSchemaWithTimestampIndexes(schema,
_timestampIndexConfigs));
+ Schema updatedSchema = updateSchemaWithTimestampIndexes(schema,
_timestampIndexConfigs);
Review Comment:
So based upon the discussions, I am going to remove this method and we are
going to go with aggregate metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
