walterddr commented on PR #9546: URL: https://github.com/apache/pinot/pull/9546#issuecomment-1282565758
> This is a great feature! I'd suggest starting a high level design on all the date and time related types, and their behaviors so that we are on the same page when implementing other types. my vote is to follow postgres ([date/time](https://www.postgresql.org/docs/current/datatype-datetime.html)) > > One main thing I want to discuss is whether to carry the time zone info with the value. Seems [PostgreSQL](https://www.postgresql.org/docs/current/datatype-datetime.html) doesn't carry time zone in `timestamp with time zone`, but does carry time zone in `time with time zone` which is quite confusing. [Presto](https://prestodb.io/docs/current/language/types.html?highlight=date#date-and-time) does carry the time zone with the value. > the above observation is incorrect - postgres doesn't STORE timezone info, it always stored as UTC. - however postgres does carry timezone while processing depending on - with `AT TIME ZONE` and `WITH TIME ZONE` the result will be converted to the desired timezone - if no timezone is used in query, query engine wide configuration can be used to set for whether to convert all timestamp to local time, or without conversion and use timestamp at UTC as is. > One benefit of carrying the time zone with the value is that we can re-construct the same value using the data_time_format and preserve the time zone info from the original input value, so I'm leaning towards the Presto convention. let's clarify on what the intent of "carrying" the timezone means, especially do we wan to support at storage time or compute time. > > cc @kishoreg @xiangfu0 @walterddr @siddharthteotia for further discussion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
