Jackie-Jiang commented on PR #9546: URL: https://github.com/apache/pinot/pull/9546#issuecomment-1281574089
This is a great feature! I'd suggest starting a high level design on all the date and time related types, and their behaviors so that we are on the same page when implementing other types. One main thing I want to discuss is whether to carry the time zone info with the value. Seems [PostgreSQL](https://www.postgresql.org/docs/current/datatype-datetime.html) doesn't carry time zone in `timestamp with time zone`, but does carry time zone in `time with time zone` which is quite confusing. [Presto](https://prestodb.io/docs/current/language/types.html?highlight=date#date-and-time) does carry the time zone with the value. One benefit of carrying the time zone with the value is that we can re-construct the same value using the data_time_format and preserve the time zone info from the original input value, so I'm leaning towards the Presto convention. cc @kishoreg @xiangfu0 @walterddr @siddharthteotia for further discussion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
