npawar commented on PR #9515: URL: https://github.com/apache/pinot/pull/9515#issuecomment-1281261483
> > lgtm! we need to mark this backward incompat because of the partitionToOffset map being removed? should we keep it around and deprecate it first? > > Strictly speaking, this is considered backward incompat. But how do you "deprecate" an API response alone? all we can do is just mark it deprecated in the java class for devs, and callout in release notes for users in next release. and in release after that we can remove it. we could also add it as API notes so it appears in swagger? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
