agavra commented on PR #9538: URL: https://github.com/apache/pinot/pull/9538#issuecomment-1270667756
> Yes, it will be much faster. We already support hashing for primary keys. But users want to avoid the hash due to collisions and hence serialize the key itself. I'm still not sure I understand. It looks like there is only one place `asBytes` is used: and thats in `HashUtils#hashPrimaryKey`. Why not change the API to: `PrimaryKey#hash( HashFunction hashFunction)` and compute the hash directly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
