agavra commented on PR #9538: URL: https://github.com/apache/pinot/pull/9538#issuecomment-1270641097
> It won't be the same, but we are not persisting it anywhere so it is okay to be not backward compatible Interesting, why are we converting it to bytes then? Where's the deserialization logic? If it's just for hashing (quickly scanning the code, it looks like that's what it's used for in some places) won't it be even faster to just compute the hash instead of serializing it to bytes and then computing the hash? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
