KKcorps commented on code in PR #9288:
URL: https://github.com/apache/pinot/pull/9288#discussion_r956629037
##########
pinot-tools/pom.xml:
##########
@@ -268,6 +270,24 @@
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
+
+ <!--
+ This dependency is needed for LaunchSparkDataIngestionJobCommand.
+ The dependency only contains a few classes and scala library which has
been excluded.
+ Hence, it will not interfere with spark-core classes present in runtime
env
+ and will use the env spark version to actually execute the spark job
+ -->
+ <dependency>
+ <groupId>org.apache.spark</groupId>
+ <artifactId>spark-launcher_${scala.version}</artifactId>
+ <version>${spark.version}</version>
+ <exclusions>
Review Comment:
This dep is pretty basic. Only contains couple of classes and one more
dependency. So including it isn't a main concern. Earlier I had included
`spark-core` which was a major one and could have caused a lot of issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
