kkrugler commented on code in PR #9288:
URL: https://github.com/apache/pinot/pull/9288#discussion_r956619509
##########
pinot-tools/pom.xml:
##########
@@ -34,6 +34,8 @@
<properties>
<pinot.root>${basedir}/..</pinot.root>
<aws.version>2.14.28</aws.version>
+ <scala.version>2.12</scala.version>
Review Comment:
Once you start pulling in Scala code, you need to ensure that every
dependency that's also using Scala is using the same version. So I think this
should go in the top-level `pom.xml` file. Also note that pinot-kafka and
pinot-spark have dependencies on Scala 2.11, which I believe will cause runtime
problems if they are on the classpath when the tool is being run (and it's
using 2.12).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
