apucher commented on code in PR #9252:
URL: https://github.com/apache/pinot/pull/9252#discussion_r952041318
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -193,7 +198,7 @@ private String getQueryResponse(String query, @Nullable
SqlNode sqlNode, String
// Validate data access
AccessControl accessControl = _accessControlFactory.create();
- if (!accessControl.hasDataAccess(httpHeaders, rawTableName)) {
+ if (!accessControl.hasAccess(rawTableName, AccessType.READ, httpHeaders,
endpointUrl)) {
Review Comment:
Similar to the above, this has similar strictness to the original
implementation. The difference here is removing the use of a deprecated method.
On a tangent, this resource shouldn't be in the controller in the first
place, rather, it should be controlled by the broker's access control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
