sajjad-moradi commented on code in PR #9252:
URL: https://github.com/apache/pinot/pull/9252#discussion_r952036337
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -193,7 +198,7 @@ private String getQueryResponse(String query, @Nullable
SqlNode sqlNode, String
// Validate data access
AccessControl accessControl = _accessControlFactory.create();
- if (!accessControl.hasDataAccess(httpHeaders, rawTableName)) {
+ if (!accessControl.hasAccess(rawTableName, AccessType.READ, httpHeaders,
endpointUrl)) {
Review Comment:
Let's not change this. Although we're reading data and AccessType.READ looks
appropriate, we need to only allow ppl who are authorized to be able to query
the data that might contain sensitive info like member information. It's
different than reading table config or some other cluster configs that might be
ok with weaker authentication level like AccessType.READ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
