klsince commented on code in PR #9242:
URL: https://github.com/apache/pinot/pull/9242#discussion_r951965006
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java:
##########
@@ -154,10 +200,23 @@ public void onSuccess(@Nullable byte[] responseBytes) {
@Override
public void onFailure(Throwable t) {
+ if (_enableQueryCancellation) {
+ String queryId = queryRequest.getQueryId();
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Remove track of running query: {} on failure",
queryId);
+ }
+ _queryFuturesById.remove(queryId);
+ }
// Send exception response.
- LOGGER.error("Exception while processing instance request", t);
+ Exception ex = new Exception(t);
+ if (t instanceof CancellationException) {
+ LOGGER.info("Query: {} got cancelled", queryRequest.getQueryId());
+ ex = (Exception) t;
+ } else {
+ LOGGER.error("Exception while processing instance request", t);
+ }
Review Comment:
yeah, should have been so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
