klsince commented on code in PR #9242:
URL: https://github.com/apache/pinot/pull/9242#discussion_r951964480
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java:
##########
@@ -54,19 +65,24 @@
* The {@code InstanceRequestHandler} is the Netty inbound handler on Pinot
Server side to handle the serialized
* instance requests sent from Pinot Broker.
*/
+@ChannelHandler.Sharable
public class InstanceRequestHandler extends
SimpleChannelInboundHandler<ByteBuf> {
private static final Logger LOGGER =
LoggerFactory.getLogger(InstanceRequestHandler.class);
// TODO: make it configurable
private static final int SLOW_QUERY_LATENCY_THRESHOLD_MS = 100;
+ private final String _instanceName;
private final TDeserializer _deserializer;
private final QueryScheduler _queryScheduler;
private final ServerMetrics _serverMetrics;
private final AccessControl _accessControl;
+ private final boolean _enableQueryCancellation;
+ private final Map<String, Future<byte[]>> _queryFuturesById = new
ConcurrentHashMap<>();
Review Comment:
sgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
