yaostartree commented on PR #9245: URL: https://github.com/apache/pinot/pull/9245#issuecomment-1221699281
After thinking about it again, I feel getting the recursive option from the input file pattern is safer and cleaner. It doesn't break existing usage and it performs better. The code is also cleaner. Adding an searchRecursively option and setting it to false by default is dangerous because it is different from existing behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
