[GitHub] [pinot] walterddr commented on a diff in pull request #9245: [Feature] List files from inputDir with recursive option based on inputFilePatterns in IngestionJobLauncher

[GitBox]

walterddr commented on code in PR #9245:
URL: https://github.com/apache/pinot/pull/9245#discussion_r950261062


##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGenerationJobRunner.java:
##########
@@ -172,7 +172,7 @@ public void init(SegmentGenerationJobSpec spec) {
   public void run()
       throws Exception {
     // Get list of files to process.
-    String[] files = _inputDirFS.listFiles(_inputDirURI, true);
+    String[] files = _inputDirFS.listFilesWithPattern(_inputDirURI, 
_spec.getIncludeFileNamePattern());

Review Comment:
   sadly we don't have any. the behavior is even worse in our current 
implementation: see: https://github.com/apache/pinot/issues/9016



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org