tanmesh commented on code in PR #9184:
URL: https://github.com/apache/pinot/pull/9184#discussion_r950488823
##########
pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/ExtractTransformFunctionTest.java:
##########
@@ -0,0 +1,60 @@
+package org.apache.pinot.core.operator.transform.function;
+
+import java.util.function.LongToIntFunction;
+import org.apache.pinot.common.function.scalar.DateTimeFunctions;
+import org.apache.pinot.common.request.context.ExpressionContext;
+import org.apache.pinot.common.request.context.RequestContextUtils;
+import org.testng.Assert;
+import org.testng.annotations.DataProvider;
+import org.testng.annotations.Test;
+
+import static org.testng.Assert.assertEquals;
+
+
+public class ExtractTransformFunctionTest extends BaseTransformFunctionTest {
+
+ @DataProvider
+ public static Object[][] testCases() {
+ return new Object[][] {
+ {"year", (LongToIntFunction) DateTimeFunctions::year},
+ {"month", (LongToIntFunction) DateTimeFunctions::month},
+ {"day", (LongToIntFunction) DateTimeFunctions::dayOfMonth},
+ {"hour", (LongToIntFunction) DateTimeFunctions::hour},
+ {"minute", (LongToIntFunction) DateTimeFunctions::minute},
+ {"second", (LongToIntFunction) DateTimeFunctions::second},
+// "timezone_hour",
Review Comment:
@Jackie-Jiang , do we want to support timezone-related methods as well? If
yes, I was planning to use the syntax `extract(<year/month/...>, <timestamp>,
<zone_name>)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
