[GitHub] [pinot] tanmesh commented on a diff in pull request #9184: [WIP] Add support for EXTRACT syntax and converts it to appropriate Pinot expression

[GitBox]

tanmesh commented on code in PR #9184:
URL: https://github.com/apache/pinot/pull/9184#discussion_r950434236


##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -752,6 +754,8 @@ private static Expression 
compileFunctionExpression(SqlBasicCall functionNode) {
       case OR:
         return compileOrExpression(functionNode);
       // BETWEEN and LIKE might be negated (NOT BETWEEN, NOT LIKE)
+      case EXTRACT:

Review Comment:
   Thanks for the insight. The default case was handling the logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org