navina commented on code in PR #9205:
URL: https://github.com/apache/pinot/pull/9205#discussion_r948321018
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/constant/ConstantMVForwardIndexReader.java:
##########
@@ -45,6 +45,9 @@ public DataType getStoredType() {
@Override
public int getDictIdMV(int docId, int[] dictIdBuffer,
ForwardIndexReaderContext context) {
+ if (dictIdBuffer.length == 0) {
Review Comment:
Discussed with @Jackie-Jiang offline. Looks like `dictIdBuffer.length > 0`
is the expected invariant for this method due to how MV column values are
stored in the bitmap. I have added some javadocs so that future contributors
are aware of this. Please do take a look. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
