nizarhejazi commented on code in PR #9086: URL: https://github.com/apache/pinot/pull/9086#discussion_r936141547
########## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/SumPrecisionAggregationFunction.java: ########## @@ -48,8 +51,11 @@ public class SumPrecisionAggregationFunction extends BaseSingleInputAggregationFunction<BigDecimal, BigDecimal> { private final Integer _precision; private final Integer _scale; + private final boolean _nullHandlingEnabled; - public SumPrecisionAggregationFunction(List<ExpressionContext> arguments) { + private final Set<Integer> _groupKeysWithNonNullValue; Review Comment: It is fixed in my local branch .. I usually mark comments as fixed as soon as I change locally, then send a new iteration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org