Jackie-Jiang commented on code in PR #8979: URL: https://github.com/apache/pinot/pull/8979#discussion_r959834727
########## pinot-core/src/main/java/org/apache/pinot/core/common/NullableRowBasedBlockValueFetcher.java: ########## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.common; + +import org.roaringbitmap.RoaringBitmap; + + +public class NullableRowBasedBlockValueFetcher extends RowBasedBlockValueFetcher { Review Comment: I see your point. The reason why I checked all the existing usage of `RowBasedBlockValueFetcher` and put this comment is that currently we are using 2 ways to read the rows in selection operators: the original usage always read the non-null values and handle the null values on the caller side; the new usage directly read the null values. I see the value of adding this new fetcher, but the inconsistent usage among selection operators can cause confusion, and potentially inconsistent performance. I'd suggest having a separate PR just for this change since it is not closely related to the purpose for this PR. All the usage of the `RowBasedBlockValueFetcher` should be consistent: handle null values within the fetcher. Regarding whether to have a boolean flag or a separate class, I don't have strong preference, but when null handling is enabled, we might end up switching between the 2 implementations based on whether the nullbitmap is empty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
